Feature: Remember allowance for kids (kids-956) #760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 22, 2024 10:51
TammiLion
reviewed
May 22, 2024
| @@ -56,15 +64,16 @@ class _EditAllowancePageState extends State<EditAllowancePage> { | |||
| const SizedBox(height: 8), | |||
| Text( | |||
| 'Which amount should be added to\n' | |||
| "your child's wallet each month?", | |||
| "your child's wallet each month?", | |||
There was a problem hiding this comment.
I think the only thing missing here is that for the generosity challenge it says "What amount should be added to the Wallet of each child each month?.", maybe we can add a bool isMultiple which exchanges this text? (or any other solution is fine)
TammiLion
reviewed
May 22, 2024
| @@ -1,5 +1,7 @@ | |||
| class EditAllowanceSuccessUIModel { | |||
| const EditAllowanceSuccessUIModel({this.amountWithCurrencySymbol}); | |||
| const EditAllowanceSuccessUIModel( | |||
| {this.amountWithCurrencySymbol, this.onClickButton}); | |||
There was a problem hiding this comment.
I think here as well we have a small text change: "Your child(ren) will receive $15 each month. You can edit this amount any time."
TammiLion
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description