Feature: Top Up Success (kids-844) #767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Daniela510
changed the title
TammiLion
reviewed
May 24, 2024
| @@ -67,7 +69,17 @@ class ChildDetailsPage extends StatelessWidget { | |||
| builder: (_) => const TopUpFailureDialog(), | |||
| ); | |||
| } else if (state is ChildTopUpSuccessState) { | |||
| // TODO Kids-844 | |||
| Navigator.push( | |||
TammiLion
reviewed
May 24, 2024
| @@ -0,0 +1,9 @@ | |||
| class TopUpSuccessUIModel { | |||
There was a problem hiding this comment.
Good work in implementing the UIModel. The only thing I would change is I would remove the "onClickButton" here as it isn't really "UI" but rather "logic". I would pass it as a parameter in the TopUpSuccessPage itself. That way when we use UIModels in our cubits the cubits don't need to know/ define the onClick.
TammiLion
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description