Change default compile to use the deploy target to be compatible with… #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… both brunch (phoenix < 1.4.0) and webpack (phoenix >= 1.4.0)
|
🚀 👍 |
|
@gjaldon, have you had a chance to take a look at this yet? |
|
Thanks for the contribution @behe 💜 Sorry I'm late to this. Been a while since I have been deploying a Phoenix app to Heroku |
|
@gjaldon would you be interested at all in having some extra maintainers around to help you? I'm the founder of gigalixir.com and we use this buildpack heavily so we'd be interested in contributing more actively. Thanks for making this great buildpack! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… both brunch (phoenix < 1.4.0) and webpack (phoenix >= 1.4.0)
Fixes #75