Skip to content
This repository has been archived by the owner on Dec 2, 2022. It is now read-only.

Class thumbnails broken #858

Closed
WINGsRealityEDU opened this issue Feb 3, 2018 · 22 comments
Closed

Class thumbnails broken #858

WINGsRealityEDU opened this issue Feb 3, 2018 · 22 comments

Comments

@WINGsRealityEDU
Copy link

Week old upgrade to Moodle 3.4.1 (Build: 20180115) PHP 7.0.0 and Essential 3.4.0.1 (Build: 2017102900).

Now any use of the Class=”thumbnails” and the hole container falls apart. Here are some images one of Essential > Style guide
essential class issue 1
The other is in our sites library
essential class issue 2

@gjb2048
Copy link
Owner

gjb2048 commented Feb 3, 2018

Fine in M3.2.

@gjb2048
Copy link
Owner

gjb2048 commented Feb 3, 2018

Is broken, don't know why, leaving for a while.

@gjb2048
Copy link
Owner

gjb2048 commented Feb 3, 2018

Not an issue in Shoelace.

@WINGsRealityEDU
Copy link
Author

WINGsRealityEDU commented Feb 3, 2018 via email

@WINGsRealityEDU
Copy link
Author

How can I help you determine what is going on? This is affecting 16 of our courses and some in use right now. Moodle debugging shows no errors.

@gjb2048
Copy link
Owner

gjb2048 commented Feb 15, 2018

Ok, could you provide a course MBZ backup (without user data) that demonstrates the issue please? Then I may have a chance of replicating locally and possibly finding a solution. If the problem is a theme one then I'll try and fix it, if it is you then I'll say it is but not explain why.

@gjb2048
Copy link
Owner

gjb2048 commented Feb 16, 2018

What web browser are you using please?

@gjb2048
Copy link
Owner

gjb2048 commented Feb 16, 2018

Ok, cannot replicate what you have as.... the style guide issue is f62e34a which has fixes that pertain only to the style guide:

screenshot-2018-2-16 moo34 administration appearance themes essential style guide

@gjb2048
Copy link
Owner

gjb2048 commented Feb 16, 2018

Therefore either a local issue with conflicting styles that is out of my control or is the theme that the course backup would demonstrate. Or provide me with the markup you are using to create thumbnails on a course.

@WINGsRealityEDU
Copy link
Author

I just finished a test on a new test server with Moodle 3.4.1+ (Build: 20180118) Version 2017111301.01 PHP 7.0 and there is no issue.
thumbtest1

On our production server that just had the Moodle 3.4.1 (Build: 20180115) PHP 7.0.0 and Essential 3.4.0.1 (Build: 2017102900) upgrade this is the LMS with the issue.
thumbtest2

I also have additional themes and the issue continues with them. I am happy to give you a copy of a course MBZ backup is to large to attached here. I can send on chapter of a book that has the issue,
backup-moodle2-activity-538-book538-20180216-1212-nu.zip
see attachment. It now seems like this it is conflicting style from here. I will keep looking and thank you for you time. Regards,

@gjb2048
Copy link
Owner

gjb2048 commented Feb 16, 2018

Getting The selected file is not a valid Moodle backup file and can't be restored.

@gjb2048
Copy link
Owner

gjb2048 commented Feb 16, 2018

Ok, fine now. Why did you put an mbz which is a zip file inside a zip file?

@gjb2048
Copy link
Owner

gjb2048 commented Feb 16, 2018

Not broken (please ignore navbar down the page - FireFox screen capture issue):

screenshot-2018-2-16 module 1 - introduction to flight training purpose of flight training

@WINGsRealityEDU
Copy link
Author

Been out and just got back in. Yha I get the same result on my test server but still broken on my production server. I am going to uninstall the Adaptable theme 1.6.0.2 (2018011502) tonight after the usage quiets down. This was the other theme that got updated at the same time as the other upgrades. The one thing I do know is all this started after the upgrades.

I think it must be what you stated "Therefore either a local issue with conflicting styles that is out of my control or is the theme that the course backup would demonstrate." I will get back after I have done the theme uninstall.

Regards,

@WINGsRealityEDU
Copy link
Author

Just wanted to report in on what I have found. I removed the Adaptable theme and nothing change so I placed it back in and added the Enlight lite theme to see if a new theme is effected and the issue is on all themes. The issue I am having may be higher up then the theme level.

@3-bits
Copy link

3-bits commented Feb 20, 2018

.thumbnail class is part of the bootstrap styles core. Adaptable do not include or overwrite this class in any way.
So the problem is located in bootstrapbase.css file.

@gjb2048
Copy link
Owner

gjb2048 commented Feb 20, 2018

Ok, not in bootstrapbase.css file (which actually does not exist) as.... I cannot replicate the issue and changing theme does not affect the issue locally. Therefore the problem is with a custom plugin (not theme) or user entered CSS / bad markup.

@WINGsRealityEDU
Copy link
Author

Thank you for your help.
Regards

@WINGsRealityEDU
Copy link
Author

Just to give you and others an update on the cause of the broken thumbnail and thumbnails class.
I just replicated it and the cause was the BigBlueButton RecordingsBN v 1.3.2 (2016051906) plugin. Before I upgraded on my test server the two classes were functional and as soon as I upgraded both classes no longer worked. I will contact Blindside Networks so they may have a look.

Regards,

@WINGsRealityEDU
Copy link
Author

Update, issue resolved.
Essential support thank you for all your help and thank you Blindside Networks support.

Regards,

@gjb2048
Copy link
Owner

gjb2048 commented Feb 28, 2018

So nothing to do with Essential?

@WINGsRealityEDU
Copy link
Author

WINGsRealityEDU commented Feb 28, 2018 via email

@gjb2048 gjb2048 closed this as completed Feb 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants