Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Retries #232

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

WIP: Retries #232

wants to merge 6 commits into from

Commits on Dec 2, 2023

  1. First pass at retries

    Still need to do sleep/backoff, etc. Hoping to remove NodataReader too.
    gjoseph92 committed Dec 2, 2023
    Configuration menu
    Copy the full SHA
    2bb5fe9 View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2023

  1. Configuration menu
    Copy the full SHA
    79d612b View commit details
    Browse the repository at this point in the history
  2. remove NodataReader

    When an `open` fails and we'd return nodata instead, we don't cache that anymore. So if the asset doesn't exist, we'll try to open it for every chunk. Unclear how much of a performance impact this will have. It's probably not ideal, because combining it with retries could be nice: retry errors first, then give up and use nodata if they persist?
    gjoseph92 committed Dec 3, 2023
    Configuration menu
    Copy the full SHA
    c31e4b0 View commit details
    Browse the repository at this point in the history
  3. driveby: add sat-stac back to test deps

    got lost in #221, which was a reasonable change, but turns out there was still a test importing it
    gjoseph92 committed Dec 3, 2023
    Configuration menu
    Copy the full SHA
    ef4993e View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2023

  1. some tests, and correct retry logic

    TODO:
    - sleep & backoff
    - figure out how to handle sleep in tests
    gjoseph92 committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    27331c6 View commit details
    Browse the repository at this point in the history
  2. start on docs

    gjoseph92 committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    d3d1e29 View commit details
    Browse the repository at this point in the history