Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mix and match options #18

Merged
merged 9 commits into from
Nov 4, 2015
Merged

Mix and match options #18

merged 9 commits into from
Nov 4, 2015

Conversation

gjtorikian
Copy link
Owner

Should close #17.

@GimliLongBow, after looking at this issue a bit, I discovered the problem: apparently, to_html needs configuration options pass to it as well:

  • Here's your original failing test: 7d3523a
  • And here's my change, passing the same options to to_html: 80d7d0d

The question now is, why is it set up like that? It seems like if you parse a doc with the specified options, to_html should render with the same options. I'm going to dig into the original libcommonmark library a bit to find out why this is like this.

@gjtorikian
Copy link
Owner Author

The question now is, why is it set up like that?

According to @jgm, there's a distinction between "parse options" and "render options," so this PR now also follows that distinction more strictly.

gjtorikian added a commit that referenced this pull request Nov 4, 2015
@gjtorikian gjtorikian merged commit 628041d into master Nov 4, 2015
@gjtorikian gjtorikian deleted the mix-and-match-options branch November 4, 2015 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Smart punctuation and hardbreaks don't mix in render_doc
2 participants