Super sexy rewrite #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
oh you ! |
| class LastModifiedAtGenerator << Generator | ||
|
|
||
| def generate(site) | ||
| %w(posts pages docs_to_write).each do |type| |
There was a problem hiding this comment.
Collections have Documents, only some of which should be written.
|
Does this also resolve the |
|
Also should I close your #20 ? |
…modified-at into last-modified-at-attr * 'last-modified-at-attr' of github.com:parkr/jekyll-last-modified-at: oh ruby subclassing... wat
|
This looks beyond great. Ready to merge if you're happy with it. |
|
@gjtorikian Have a bunch more tests to write – I'll ping you when I'm done 😄 |
|
@gjtorikian Done! Ready4u. |
| before(:each) { site.process } | ||
|
|
||
| it "understands happiness" do | ||
| expect(File.read(subject)).to match(/19\-Jul\-14/) |
There was a problem hiding this comment.
This is causing the test to fail on Travis. Maybe it should be set to Time.now and transformed with %e-%m-%y?
|
OH YES |
|
Pretty sure I understand about 45% of this so I'll just mergit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a custom class that can be used by either the tag or the attribute!