Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When passing Determinator to Liquid, give a Time. #27

Merged
merged 1 commit into from
Aug 26, 2014
Merged

When passing Determinator to Liquid, give a Time. #27

merged 1 commit into from
Aug 26, 2014

Conversation

parkr
Copy link
Contributor

@parkr parkr commented Aug 26, 2014

This means the formatting does not happen in #to_liquid.

Fixes #25

@gjtorikian
Copy link
Owner

@parkr amazeballs. Can you add a test to this, pretty please? ☺️

This means the formatting does *not* happen in `#to_liquid`.
@parkr
Copy link
Contributor Author

parkr commented Aug 26, 2014

@gjtorikian DONE 😄

@gjtorikian
Copy link
Owner

You're the best! (the beee~eest)

Also this is totally great now that you're on P S T.

gjtorikian added a commit that referenced this pull request Aug 26, 2014
When passing Determinator to Liquid, give a Time.
@gjtorikian gjtorikian merged commit be89ec0 into gjtorikian:master Aug 26, 2014
@parkr parkr deleted the patch-2 branch August 26, 2014 06:10
@parkr
Copy link
Contributor Author

parkr commented Aug 26, 2014

always a pleasure to work with the coolest dude in town ☺️

west coast, best coast. pacific time...... best time.

ok sleep time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

{{ page.last_modified_at | date }}
2 participants