Use posix-spawn instead of Open3. #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gjtorikian Have you had time to try this? |
|
I have not yet 😭 |
|
Still want this? Should be faster. |
|
Why not? |
gjtorikian
added a commit
that referenced
this pull request
Jun 15, 2015
Use posix-spawn instead of Open3.
|
Looooool you're the greatest. |
|
Thanks ❤️ |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok, honestly not sure how much this will improve things, but perhaps, perhaps, perhaps it will shave a few seconds off that 10s number. Would you mind testing with that site and reporting if there's any speed boost?
Best option would be to use C-bindings in Git... maybe use Rugged or something instead of shelling out at all? Who could we ask about that?