Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added configuration #76

Merged
merged 3 commits into from
Apr 30, 2020
Merged

Added configuration #76

merged 3 commits into from
Apr 30, 2020

Conversation

socram8888
Copy link
Contributor

This small modifications adds configurable options. Namely, it allows to change the default format (with the default being the current one), and an option to set the timezome to UTC (disabled by default).

Setting the timezone to UTC is IMHO pretty important and useful if the website is not build on a local PC but on a site such as GitHub Actions or any other pipeline where the timezone may change between runs.

@socram8888
Copy link
Contributor Author

I just realized I had missed the timezone option in the _config.yml. D'oh.

I should probably remove the whole UTC thing and keep only the option to have a custom default, right?

@gjtorikian
Copy link
Owner

Oh, this is cool. Does Jekyll use date_format anywhere on its own? I'd hate for this plugin to add its own config if one already exists.

@socram8888
Copy link
Contributor Author

Jekyll does not seem to have it implemented at all - the documentation at least mentions no such feature existing.

This same key name is used by another plugin already, however.

@gjtorikian
Copy link
Owner

Hmmm. I think I'd still rather not interfere since I don't know what Jekyll will do in the future.

How about we change it to:

jekyll-last-modified-at:
   date_format: <xxx>

in the config.yaml? That way we can add timezone or anything else in the future.

@socram8888
Copy link
Contributor Author

socram8888 commented Apr 29, 2020

Done. First commit (582061e) fixes that Jekyll is in UTC but the Time.now call was not, and at this time of the night (0:32 CEST) it was failing.

@gjtorikian
Copy link
Owner

Thanks, this is great. I'll release this as a new minor version now.

@gjtorikian gjtorikian merged commit 7870d01 into gjtorikian:master Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants