Update uthash and cmake #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resolves most errors during the cmake build.
Merged
|
LGTM. I just changed the builds to use GitHub actions, but, because this is a fork, I don't think it's going to run. I'm merging this (I also tested locally), will deal with the CI issues 🔜 . And I'm going to rename the base branch to Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates cmake to 2.3.0, and modernizes the CMakeLists file.
Test plan:
ran ctest
ran ctest -T memorycheck on both master and this branch, and observed similar memory behaviour (3 errors)
ran mathematical tests (all pass)
Resolves #59