Feature #36 HSP color space, and color.brightness() #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don’t think this should be merged, because as I wrote in #36 (comment), HSP seems strictly worse than the similar HSLuv color space. If any color space like this is implemented, it should be HSLuv, so that the colors people generate will have perceptually uniform hues. |
|
would love to see HSLuv in chroma <3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
based on feature request #36, I implemented the HSP color space as explained in [1].
Additionally, similar to color. luminance(), I implemented color.brightness() that returns the perceived brightness P of HSP as a standalone function.
Missing: Interpolation between two colors in hsp. I wasn't sure about these lines in colors.coffee.
[1] http://alienryderflex.com/hsp.html