flows tooltip to the top, unless it overflows viewport and there's space below cursor to accommodate tooltip #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flows tooltip to the top, unless it overflows and has space below
|
Is the Math.max necessary? What about:
|
|
Works for me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses attachTooltip: Flow tooltip towards top, unless it overflows viewport and there's space below to accommodate tooltip #39
not committing
./build/d3v4+jetpack.js, because it seems to have been built withd3@4.7.3, while the current d3v4 is a bit ahead (v4.10.2).