Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.4.0 changes #205

Merged
merged 163 commits into from
May 25, 2021
Merged

v0.4.0 changes #205

merged 163 commits into from
May 25, 2021

Conversation

gkjohnson
Copy link
Owner

@gkjohnson gkjohnson commented Mar 4, 2021

TODO

  • Fix LGTM exclude
  • Update point cloud demo shapecast call, remove lazy generation option
  • Re-add rollup esm, umd to /builds folder for users that copy files
  • Add dev-bundle folder
  • Clean up sculpt example
  • Include an offset inclusive of the other geometry group nodes in the returned node indices for the sake of refit.
  • Sculpt: Refit performance improvement
  • Sculpt: Update triangle iteration function to take triangle index
  • Sculpt: Remove BVH helper from scene when not visible
  • Sculpt: Only update helper when not visible
  • Change shapecast to take object of callbacks (Fix Update shapecast function #218)
  • Change shapecast to provide a triangle range callback (Fix Adjust shapecast function to provide triangle ranges #173)
  • refit tests
  • Add touch to collect triangles, sculpt examples
  • Retain index, position attribute references Retain reference to index, position buffer, geometry #206
    • remove geometry argument from "refit"
  • Only generate normals once at the end of all the steps
  • Consider computing the average normal and point in the triangle callback instead of after
  • Max steps to 10, maximum value to 25
  • Disable frustum culling and / or clear the bounding boxes for the target mesh when refitting the bounds
  • For flatten brush position the plane at the average point so we can include steps without refit
  • Flatten / smooth stroke
  • Sculpt comments
  • Check mouse distance movement in world space rather than screen space
  • Improve initial brush settings
  • Fix Example: Add sculpting example #186
  • Fix brush behavior
    • Use average points for the sculpt normal (average normals)
    • Iterate multiple steps with a threshold scaled by brush radius
  • Docs (refit function, sculpt example)
  • Make issue for sculpt example performance improvement (Example: Improve Sculpt Example #207)
    • Give hints to refit function
    • Improve normal generation performance
    • Improve geometry generation performance
    • Add support for simplification and tessellation
  • Remove "buffer" from cast function names
  • Add refitBounds function (add benchmark)
  • Find clay matcap
  • Update sculpt example to use range function (Improve shapecast range intersect function return options #229)
  • root node does not fully contain child nodes after rebuild Root BVH bounds are incorrect if geometry.boundingBox is out of date #222
    • it's possibly just the visualization helper?
    • Fixes itself on refit call
    • This is because the geometry bounding box is out of date and yields an incorrect root bounds. We should be able to guarantee a correct bounds by taking the union of the children or just removing the check for an existing bounds. Or update docs stating the bounding box is expected to be up to date?
  • Perf could be improved by removing redundant vector reads. We only need unique triangle vertex indices out of the shapecast run to process later. Update shapecast function #218
    • Provide shapecast callback that just gets fired with triangle ranges
    • Adjust shapecast to take an object of functions so it's more convenient to call and log deprecation warning if the first argument is a function.

Repository owner deleted a comment from lgtm-com bot Mar 12, 2021
Repository owner deleted a comment from lgtm-com bot Mar 13, 2021
Repository owner deleted a comment from lgtm-com bot May 13, 2021
Repository owner deleted a comment from lgtm-com bot May 21, 2021
Repository owner deleted a comment from lgtm-com bot May 22, 2021
@lgtm-com
Copy link

lgtm-com bot commented May 22, 2021

This pull request introduces 11 alerts when merging 080ff1e into 5918f0b - view on LGTM.com

new alerts:

  • 11 for Unused variable, import, function or class

@gkjohnson gkjohnson merged commit 97e32fd into master May 25, 2021
@gkjohnson gkjohnson deleted the dev-v0.4.0 branch May 25, 2021 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant