dep bug (v1.5.0 CLI): jison 0.4.17 broke API in a minor release

[summivox]

write file a.ls:

if
else
  ...

run in shell:

lsc -cw *.ls

results in:

Failed at: a.ls
C:\Users\summi\AppData\Roaming\npm\node_modules\livescript\lib\command.js:260
            warn(e + '\x07');
                   ^

TypeError: Function.prototype.toString is not generic
    at compileScript (C:\Users\summi\AppData\Roaming\npm\node_modules\livescript\lib\command.js:260:20)
    at C:\Users\summi\AppData\Roaming\npm\node_modules\livescript\lib\command.js:152:11
    at C:\Users\summi\AppData\Roaming\npm\node_modules\livescript\lib\command.js:142:7
    at FSReqWrap.readFileAfterClose [as oncomplete] (fs.js:439:3)

Turns out:

diff --git a/lib/parser.js b/lib/parser.js
index bba7afc..4cf0e84 100644
--- a/lib/parser.js
+++ b/lib/parser.js
@@ -1,4 +1,4 @@
-/* parser generated by jison 0.4.15 */
+/* parser generated by jison 0.4.17 */
 /*
   Returns a Parser object of the following structure:

@@ -781,7 +781,13 @@ parseError: function parseError(str, hash) {
     if (hash.recoverable) {
         this.trace(str);
     } else {
-        throw new Error(str);
+        function _parseError (msg, hash) {
+            this.message = msg;
+            this.hash = hash;
+        }
+        _parseError.prototype = Error;
+
+        throw new _parseError(str, hash);
     }
 },

Noticed the noob line yet?

        _parseError.prototype = Error;

Yikes, new _parseError is a Function. This is... sort of okay (while unintended) until in command.ls:

  catch then if e?
    if LiveScript.listeners 'failure' .length
      LiveScript.emit 'failure' e, t
    else
      warn "Failed at: #filename" if filename
      unless e instanceof SyntaxError or /^Parse error /test e.message
        e = e.stack or e
      if o.watch then warn e + '\7'
                 else die  e
    return

Unfortunately node.js as of now does not allow coercion of a Function (e here) to string (e + '\7').

Suggestion:

1. pin down jison version for now
2. notify them of this bug
3. maybe use e.message + '\7' for now

[summivox]

Edit: Seems that someone already filed this bug in jison:

zaach/jison#328

[vendethiel]

this should be reopened, the bug still happens regularly when using -cw

[rhendric]

Repro, @vendethiel? I can't reproduce with the original report.

[vendethiel]

I patched it locally. I'll have to remove the patch and check next time, but pretty much everytime I write invalid code I get this behavior.