New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for <expr> by <expr> loops #837

Merged
merged 2 commits into from Feb 2, 2016

Conversation

Projects
None yet
2 participants
@rhendric
Collaborator

rhendric commented Feb 1, 2016

It was already in the grammar, but the lexer was written such that it could never happen.

As a special case, for by in foo still treats by as an identifier rather than a keyword.

@vendethiel

This comment has been minimized.

Contributor

vendethiel commented Feb 2, 2016

Can you please add a test with said special case? I'll merge it after that :)

@rhendric

This comment has been minimized.

Collaborator

rhendric commented Feb 2, 2016

It already exists! test/loop.ls, line 168

@vendethiel

This comment has been minimized.

Contributor

vendethiel commented Feb 2, 2016

Ah ok, you merely added it for that.

vendethiel added a commit that referenced this pull request Feb 2, 2016

Merge pull request #837 from rhendric/for-by
support for <expr> by <expr> loops

@vendethiel vendethiel merged commit 49416ac into gkz:master Feb 2, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@vendethiel

This comment has been minimized.

Contributor

vendethiel commented Feb 2, 2016

Thanks again!

This was referenced Jan 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment