Fix #45: Unable to initialize device with injected key #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gl-sergei
force-pushed
the
fix45
branch
2 times, most recently
from
b0c0f74
to
4bd6422
Compare
1. Change inject_key.py to preserve this flash storage layout: - 1KiB attestation certificate and key - 1KiB device key - 1KiB auth counter 2. Change cert/gen.sh and friends to produce the same flash layout as above
u2f_attestation_cert_initialize instantiated temporary buffer to hold "struct attestation_cert". After struct size was padded to 1KiB, this code started to led to stack overrun. Fix is to separate certificate header (length and pointers) from the data and instantiate only header.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change inject_key.py to preserve this flash storage layout:
Change cert/gen.sh and friends to produce the same flash layout as above