Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent NaN% widths for blank runs #16

Closed
glacials opened this issue Jan 28, 2014 · 0 comments
Closed

Prevent NaN% widths for blank runs #16

glacials opened this issue Jan 28, 2014 · 0 comments
Labels
bug Issues that are solved by repairing functionality

Comments

@glacials
Copy link
Owner

Other than for testing I'm not sure why you'd upload a blank run, but if you do we end up dividing by 0 all over the place which means we get bars with NaN% widths.

I guess the most sane way to display the splits timeline would be to give each split an equal amount of space by using widths of 100/num_splits%. Obviously this isn't technically accurate, but the only accurate way to handle this would be to blow up. So it'll have to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues that are solved by repairing functionality
Projects
None yet
Development

No branches or pull requests

1 participant