Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Segment group durations artificially short when a split is skipped #819

Open
glacials opened this issue Jul 13, 2022 · 0 comments
Open

Segment group durations artificially short when a split is skipped #819

glacials opened this issue Jul 13, 2022 · 0 comments
Labels
bug Issues that are solved by repairing functionality good first issue Issues that don't need a ton of context to address small Issues that probably won't take much work to address

Comments

@glacials
Copy link
Owner

We calculate segment group durations based on the sum of their segments' durations, but if a segment was skipped its duration is 0 so the group's duration is artificially low. Example: Discord report, splits

We should probably instead calculate the duration based on the group's last split end time, if present.

Relevant code
@glacials glacials added bug Issues that are solved by repairing functionality small Issues that probably won't take much work to address good first issue Issues that don't need a ton of context to address labels Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Issues that are solved by repairing functionality good first issue Issues that don't need a ton of context to address small Issues that probably won't take much work to address
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@glacials