Merge pull request #48 from gladly-team/kevin/disable-emx

Remove EMX Digital for late, unpaid receivables
gladly-team · Oct 19, 2022 · 59e8446 · 59e8446
2 parents 0b5caa5 + ba72f0c
commit 59e8446
Show file tree

Hide file tree

Showing 6 changed files with 34 additions and 34 deletions.
diff --git a/README.md b/README.md
@@ -91,7 +91,8 @@ Here's what to check for each partner, assuming the iframed page is `https://exa
 
 | Partner | Request URL | What to check |
 | ------------- | ------------- | ------------- |
-| EMX Digital  | `hb.emxdgt.com`  | Payload `site.domain` is `example.com`; `site.page` and `site.ref` are both `https://example.com/newtab/`  |
+[//]: # Disabled EMX Oct 19, 2022, for unpaid receivables.
+[//]: # (| EMX Digital  | `hb.emxdgt.com`  | Payload `site.domain` is `example.com`; `site.page` and `site.ref` are both `https://example.com/newtab/`  |)
 | Magnite  | `https://fastlane.rubiconproject.com/a/api/fastlane.json`  | Query param `rf` is `https://example.com/newtab/` |
 | Media.net  | `https://prebid.media.net/rtb/prebid`  | Payload `site.domain` is `example.com` and `site.page` is `https://example.com/newtab/`  |
 | OpenX  | `https://tabforacause-d.openx.net/w/1.0/arj`  | Query param `ju` is `https://example.com/newtab/` |

diff --git a/src/providers/prebid/__tests__/prebidBidder.test.js b/src/providers/prebid/__tests__/prebidBidder.test.js
@@ -191,7 +191,6 @@ describe('prebidBidder: fetchBids', () => {
     const adUnitConfig = pbjs.addAdUnits.mock.calls[0][0]
 
     expect(adUnitConfig[0].bids.map((bid) => bid.bidder).sort()).toEqual([
-      'emx_digital',
       'medianet',
       'openx',
       'pulsepoint',
@@ -202,7 +201,6 @@ describe('prebidBidder: fetchBids', () => {
       'yahoossp',
     ])
     expect(adUnitConfig[1].bids.map((bid) => bid.bidder).sort()).toEqual([
-      'emx_digital',
       'medianet',
       'openx',
       'pulsepoint',
@@ -213,7 +211,6 @@ describe('prebidBidder: fetchBids', () => {
       'yahoossp',
     ])
     expect(adUnitConfig[2].bids.map((bid) => bid.bidder).sort()).toEqual([
-      // 'emx_digital',
       'medianet',
       'openx',
       'pulsepoint',
@@ -451,7 +448,7 @@ describe('prebidBidder: fetchBids', () => {
         {
           adId: 'div-gpt-ad-1464385677836-0',
           revenue: 0.19 / 1000,
-          advertiserName: 'emxdigital',
+          advertiserName: 'unruly',
           adSize: '728x90',
           encodedRevenue: null,
         },
@@ -510,7 +507,7 @@ describe('prebidBidder: fetchBids', () => {
         {
           adId: 'div-gpt-ad-1464385677836-0',
           revenue: 0.19 / 1000,
-          advertiserName: 'emxdigital',
+          advertiserName: 'unruly',
           adSize: '728x90',
           encodedRevenue: null,
         },

diff --git a/src/providers/prebid/built/pb.js b/src/providers/prebid/built/pb.js
diff --git a/src/providers/prebid/modules.json b/src/providers/prebid/modules.json
@@ -1,7 +1,6 @@
 [
   "consentManagement",
   "consentManagementUsp",
-  "emx_digitalBidAdapter",
   "medianetBidAdapter",
   "openxBidAdapter",
   "rubiconBidAdapter",

diff --git a/src/providers/prebid/prebidBidder.js b/src/providers/prebid/prebidBidder.js
@@ -72,14 +72,16 @@ const getPrebidAdUnit = (tabAdUnit, config) => {
               delDomain: 'tabforacause-d.openx.net',
             },
           },
+          // Disabled EMX Oct 19, 2022, for unpaid receivables.
+          // If reenabling, be sure to add their adapter back in.
           // EMX Digital was formerly brealtime.
           // http://prebid.org/dev-docs/bidders.html#emx_digital
-          {
-            bidder: 'emx_digital',
-            params: {
-              tagid: '29672',
-            },
-          },
+          // {
+          //   bidder: 'emx_digital',
+          //   params: {
+          //     tagid: '29672',
+          //   },
+          // },
           {
             bidder: 'unruly',
             params: {
@@ -152,12 +154,14 @@ const getPrebidAdUnit = (tabAdUnit, config) => {
               delDomain: 'tabforacause-d.openx.net',
             },
           },
-          {
-            bidder: 'emx_digital',
-            params: {
-              tagid: '29673',
-            },
-          },
+          // Disabled EMX Oct 19, 2022, for unpaid receivables.
+          // If reenabling, be sure to add their adapter back in.
+          // {
+          //   bidder: 'emx_digital',
+          //   params: {
+          //     tagid: '29673',
+          //   },
+          // },
           {
             bidder: 'unruly',
             params: {

diff --git a/src/utils/test-utils.js b/src/utils/test-utils.js
@@ -222,7 +222,7 @@ export const mockPrebidBidResponses = () => ({
         height: 90,
       }),
       mockPrebidBid({
-        bidder: 'emxdigital',
+        bidder: 'unruly',
         cpm: 0.19,
         width: 728,
         height: 90,