Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support server-side rendering of the tab-ads JS #6

Merged
merged 11 commits into from
Mar 25, 2020
Merged

Conversation

kmjennison
Copy link
Contributor

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #6 into master will decrease coverage by 0.46%.
The diff coverage is 93.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #6      +/-   ##
==========================================
- Coverage   98.89%   98.43%   -0.47%     
==========================================
  Files          26       29       +3     
  Lines         545      576      +31     
  Branches       93       98       +5     
==========================================
+ Hits          539      567      +28     
- Misses          6        8       +2     
- Partials        0        1       +1     
Impacted Files Coverage Δ
src/AdComponent.js 100.00% <ø> (ø)
src/providers/prebid/prebidBidder.js 97.82% <ø> (ø)
src/utils/getGlobal.js 50.00% <50.00%> (ø)
src/displayAd.js 89.47% <100.00%> (+0.58%) ⬆️
src/fetchAds.js 100.00% <100.00%> (ø)
src/getBidders.js 100.00% <100.00%> (ø)
src/google/getGoogleTag.js 100.00% <100.00%> (ø)
src/index.js 100.00% <100.00%> (ø)
src/providers/amazon/getAmazonTag.js 100.00% <100.00%> (ø)
src/providers/indexExchange/getIndexExchangeTag.js 100.00% <100.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6837a0b...515c39b. Read the comment docs.

@kmjennison kmjennison merged commit 8daa9ea into master Mar 25, 2020
@kmjennison kmjennison deleted the kevin/isomorphic branch March 25, 2020 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants