Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INSECURE TEST 2 - delete test. Test count: 1 #3

Closed
wants to merge 1 commit into from
Closed

INSECURE TEST 2 - delete test. Test count: 1 #3

wants to merge 1 commit into from

Conversation

glasnt-dev
Copy link

No description provided.

@glasnt
Copy link
Owner

glasnt commented Nov 23, 2022

Code used https://github.com/glasnt/pull_request_target_demo/blob/ae87ca98928e2c04b717cdce74f134500ac9e337/.github/workflows/test.yml

Highlight: uses pull_request_target (gives access to secret)

and pulls in PR code (THIS IS INSECURE)

ref: "refs/pull/${{ github.event.number }}/merge" # THIS IS INSECURE

@glasnt
Copy link
Owner

glasnt commented Nov 23, 2022

pytest output:

============================= test session starts ==============================
platform linux -- Python 3.11.0, pytest-7.2.0, pluggy-1.0.0
rootdir: /home/runner/work/pull_request_target_demo/pull_request_target_demo
collected 1 item

test_secret.py .                                                         [[10](https://github.com/glasnt/pull_request_target_demo/actions/runs/3528604463/jobs/5918884284#step:5:11)0%]

============================== 1 passed in 0.01s ===============================

@glasnt-dev glasnt-dev closed this by deleting the head repository Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants