broken ast for `$$$$$`

[alexander-akait]

Input:

get_class($var)::$$$$$property;

Two problem:

• leading comments property 😕

Variable {
        kind: 'variable',
        leadingComments:
         Location {
           source: '$$$$property',
           start: Position { line: 3, column: 18, offset: 25 },
           end: Position { line: 3, column: 30, offset: 37 } },
        name:
         Variable {
           kind: 'variable',
           leadingComments:
            Location { source: '$$$property', start: [Position], end: [Position] },
           name:
            Variable {
              kind: 'variable',
              loc: [Location],
              name: [Variable],
              byref: false,
              curly: false },
           byref: false,
           curly: false },
        byref: false,
        curly: false }

• invalid count of variable nodes (now is 4), but should be 5

Simple example:

get_class($var)::$$property;

Output from php parser:

array(
    0: Stmt_Expression(
        expr: Expr_StaticPropertyFetch(
            class: Expr_FuncCall(
                name: Name(
                    parts: array(
                        0: get_class
                    )
                )
                args: array(
                    0: Arg(
                        value: Expr_Variable(
                            name: var
                        )
                        byRef: false
                        unpack: false
                    )
                )
            )
            name: Expr_Variable(
                name: Expr_Variable(
                    name: Expr_Variable(
                        name: Expr_Variable(
                            name: property
                        )
                    )
                )
            )
        )
    )
)

[ichiriac]

related to https://github.com/glayzzle/php-parser/blob/master/src/parser/variable.js#L162

In principle this should also be afected : $foo::${$bar} and, should also be a problem on ->

I'll investigate

[ichiriac]

It's fixed, variable names can be variables. also the ${ it's now a variable with the curly = true property.

For the implementation of the offset on StaticLookup or PropertyLookup, you can have :

• an identifier $foo::bar
• a variable (curly = false) $foo::$bar (the variable name can be a variable...)
• a variable (curly = true) $foo::${bar} (the variable name can be an expression...)
• an Encapsed : $foo::bar_$baz
• any other case meaning it's an expression like $foo::{expr($bar)}

[ichiriac]

Ok, after working on #128 I've introduced an simplification, the $foo->{bar} is now wrapped by a Literal node, containing the expression on the value property