-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't have curly for propertylookup in offset #128
Comments
This might be a duplicate of #101 |
Not really, here the problem is about unclear AST. In fact it's not really a bug as the output can be resolved as following : If the I find it a bit ugly, so I'll use this version in order to introduce changes on AST and make it more intuitive, related on #62 |
Oh, of course - and it's not even about |
@ichiriac the workaround in our prettier plugin is actually not too bad: prettier/plugin-php#183 |
/cc @ichiriac friendly ping, after some delay let's solve this issue, any ideas how better solve this? |
Hi @evilebottnawi, I'm sorry that my reply took so long, I'm almost free & back now. I'll work this saturday all the day, I still plan to release it on a stable version soon. I wish you an happy new year plenty of joy and cool projects 😄 |
Hi @evilebottnawi, Could you check remaining issues and add the flag high-pri on every issue you need to be fixed for the stable version ? Like this I'll know on what to focus. |
hi, it's implemented, take a look at the comment #248 (comment) in order to see the implementation rules |
Example:
Ref: prettier/plugin-php#112
The text was updated successfully, but these errors were encountered: