Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tests & performance from latest release #95

Closed
3 tasks done
ichiriac opened this issue Nov 5, 2017 · 2 comments
Closed
3 tasks done

Improve tests & performance from latest release #95

ichiriac opened this issue Nov 5, 2017 · 2 comments

Comments

@ichiriac
Copy link
Member

ichiriac commented Nov 5, 2017

Issue initialized here : #94

  • Should improve coverage on latest 2.1.0 release
  • Should improve performance by checking is('IDENTIFIER') at last
  • Add a performance indicator test
@ichiriac
Copy link
Member Author

ichiriac commented Nov 5, 2017

Start a generic test, does not covers everything but can indicate if some generic behaviour becomes slower. Here my actual results, based on my virtual machine

  Performance tests
    + Tokens speed  => 1.13M/sec
    + Reading speed => 2.18M/sec
    ✓ tokenizer (118ms)
    + Nodes speed  => 137.58K/sec
    + Overall speed => 880.01K/sec
    ✓ parser (293ms)

ichiriac added a commit that referenced this issue Nov 5, 2017
ichiriac added a commit that referenced this issue Nov 5, 2017
ichiriac added a commit that referenced this issue Nov 5, 2017
ichiriac added a commit that referenced this issue Nov 5, 2017
@ichiriac ichiriac added the bug label Nov 5, 2017
ichiriac added a commit that referenced this issue Nov 5, 2017
@ichiriac
Copy link
Member Author

ichiriac commented Nov 5, 2017

Seems to be an overall boost ✨ 🎆 👍

New test takes 498sec to parse 48200 files :
https://travis-ci.org/glayzzle/php-parser-dev/builds/297672428#L889

From v2.1.0 it takes 620 sec :
https://travis-ci.org/glayzzle/php-parser-dev/builds/295681042#L896

And latest 2.0.7 takes 892 sec :
https://travis-ci.org/glayzzle/php-parser-dev/builds/271363662#L1290

May not run on same machine with same frequency, and may share CPU with other builds, so I can't conclude that's fully on code optimisation...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant