Added suggested performance optimization #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @bbtgp, Many thanks 👍 There will be just a little problem on graceful mode (not sure, not tested yet). I don't want to abuse your time so tell me if you're done, I can patch it myself if needed. |
ichiriac
requested changes
Nov 4, 2017
src/parser/variable.js
Outdated
| if(this.token === this.tok.T_OBJECT_OPERATOR || this.token === this.tok.T_DOUBLE_COLON) { | ||
| this.error(); | ||
| } else { |
There was a problem hiding this comment.
possible infinite loop and node may missing in graceful mode
ichiriac
approved these changes
Nov 4, 2017
|
Should pass now, I just need to add some regression tests on it, I'll merge it soon and release it under 2.1.1 as a bugfix |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I switched the expressions around in the conditions for class.js and variable.js and removed the T_CLASS check that was not needed.
Cheers!