Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve Declare node and introduce DeclareDirective node #242

Merged
merged 1 commit into from
Nov 18, 2018
Merged

feat: improve Declare node and introduce DeclareDirective node #242

merged 1 commit into from
Nov 18, 2018

Conversation

alexander-akait
Copy link
Collaborator

  • Introduce DeclareDirective node ( key (is identifier)/value)
  • Rename what to directives for Declare node
  • Declare can have multiple directive (now it is array).
  • Tests

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 95.481% when pulling a0338ae on feat-declare-and-declare-directive into 940e0d0 on master.

ichiriac
ichiriac approved these changes Nov 18, 2018
View reviewed changes
Copy link
Member

@ichiriac ichiriac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 💯 that's exactly the kind of change I want to do in order to complete the new release : #62

Thanks !

@ichiriac
Copy link
Member

Maybe the Entry node from array could also inherit from node same as the DeclareDirective

@ichiriac ichiriac merged commit 5b205cd into master Nov 18, 2018
@ichiriac ichiriac added this to the 3.0.0-prerelease.9 milestone Jan 7, 2019
@alexander-akait alexander-akait deleted the feat-declare-and-declare-directive branch January 18, 2019 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ichiriac ichiriac ichiriac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0-prerelease.9
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alexander-akait @coveralls @ichiriac