-
-
Notifications
You must be signed in to change notification settings - Fork 725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support git deps with build tool #1338
Comments
I'd like to have a look at this, but would do #1409 first as that is the basis for this issue. |
I have been experimenting with this feature locally, and would like to discuss some of my findings so we can better define what to do next. First, I noticed that there are two moments within
Therefore, in my initial approach, I simply cloned the Git dependency to However, I still haven't decided on the best solution for the "detecting the need for a clone" part. This is because the happy path I was considering is when I've thought of two approaches so far:
Approach 2 seems the most sane to me, but it does kind of entangle Some additional questions:
Also, regarding #2899, it's worth noting that I don't think we'd have much trouble making the two feature requests work together, at least based on my POC. So the main focus on the discussion should probably be the points above, in principle. |
Maybe also support git_package = { git = "git@github.com:gleam-lang/stdlib.git", branch = "otp-28-support" } |
Gleam only, no need for rebar3 currently
https://github.com/elixir-lang/elixir/blob/79cd891eb86ecb7654a7acdb63769cfdd950a5c0/lib/mix/lib/mix/scm/git.ex
Anything else? Can't think of anything.
Config
The text was updated successfully, but these errors were encountered: