Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to prevent requests vs urllib3 clash #155

Merged
merged 1 commit into from
Aug 3, 2023
Merged

Try to prevent requests vs urllib3 clash #155

merged 1 commit into from
Aug 3, 2023

Conversation

alyssaruth
Copy link
Contributor

The IntelliJ install check blows up for me if I used daktari with a fresh venv. It's fine for my local install - the difference is that currently a venv gets urlib3 on version 2.x. That major version is incompatible with the requests library - there's an open issue about it.

Since we depend on requests, enforce the lower version of urllib3 to avoid this 🙏

DEBUG:root:Exception running check intellij.installed
Traceback (most recent call last):
  File "/home/alyssa/.asdf/installs/daktari/0.0.121/venv/lib/python3.8/site-packages/daktari/check_runner.py", line 54, in run_check_in_try
    return check.check()
  File "/home/alyssa/.asdf/installs/daktari/0.0.121/venv/lib/python3.8/site-packages/daktari/checks/intellij_idea.py", line 121, in check
    intellij_version = get_intellij_idea_version()
  File "/home/alyssa/.asdf/installs/daktari/0.0.121/venv/lib/python3.8/site-packages/daktari/checks/intellij_idea.py", line 106, in get_intellij_idea_version
    return get_intellij_idea_version_snap() or get_intellij_idea_version_tarball()
  File "/home/alyssa/.asdf/installs/daktari/0.0.121/venv/lib/python3.8/site-packages/daktari/checks/intellij_idea.py", line 62, in get_intellij_idea_version_snap
    snaps_req = session.get(
  File "/home/alyssa/.asdf/installs/daktari/0.0.121/venv/lib/python3.8/site-packages/requests/sessions.py", line 602, in get
    return self.request("GET", url, **kwargs)
  File "/home/alyssa/.asdf/installs/daktari/0.0.121/venv/lib/python3.8/site-packages/requests/sessions.py", line 589, in request
    resp = self.send(prep, **send_kwargs)
  File "/home/alyssa/.asdf/installs/daktari/0.0.121/venv/lib/python3.8/site-packages/requests/sessions.py", line 703, in send
    r = adapter.send(request, **kwargs)
  File "/home/alyssa/.asdf/installs/daktari/0.0.121/venv/lib/python3.8/site-packages/requests/adapters.py", line 486, in send
    resp = conn.urlopen(
  File "/home/alyssa/.asdf/installs/daktari/0.0.121/venv/lib/python3.8/site-packages/urllib3/connectionpool.py", line 790, in urlopen
    response = self._make_request(
  File "/home/alyssa/.asdf/installs/daktari/0.0.121/venv/lib/python3.8/site-packages/urllib3/connectionpool.py", line 496, in _make_request
    conn.request(
TypeError: request() got an unexpected keyword argument 'chunked'
💥 [intellij.installed] Check failed with unhandled TypeError

@alyssaruth alyssaruth merged commit b1acd02 into main Aug 3, 2023
4 checks passed
@alyssaruth alyssaruth deleted the pin-url-lib3 branch August 3, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants