Google Translator: Improves newline handling #597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The newline replacement only worked when extra spaces were added by Google Translate API, which is not always happening. - Adds some more tests to catch this and changes the replacement to be closer to replacing of interpolations. - Fixes #595 This is a frustating bug that has been open for many years: https://issuetracker.google.com/issues/119256504?pli=1 Maybe one of the other APIs are more consistent.
glebm
approved these changes
Sep 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by Google Translate API, which is not always happening.
be closer to replacing of interpolations.
<br id=i18n />is not replaced with newline after translation #595This is a frustating bug that has been open for many years:
https://issuetracker.google.com/issues/119256504?pli=1
Maybe one of the other APIs are more consistent.