-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add note about --quality
option
#78
Add note about --quality
option
#78
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Do we have a list of accepted compression types somewhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR adds clarity and important information about the range and values for the --quality
flag used with compression that was missing before. The explanation is thorough and straightforward with good examples and starting value for users.
Looks good.
@DavidStirling As far as I know the only way to see the list of accepted compression is with
Maybe we should open another PR, either listing the compression types or adding the output of |
Looks good to me. Very useful info. |
Thank you very much @melissalinkert for the detailed sequence of pointers! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
/cc @muhanadz @mgheirat @DavidStirling @erindiel