-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump dependencies to formats-bsd 6.10.1 and jzarr 0.3.5 #84
Conversation
This change aligns the dependencies of raw2ometiff with the ones of bioformats2raw 0.5.0
is identical to the build failure on the HEAD of the base branch - see https://ci.appveyor.com/project/gs-jenkins/raw2ometiff/builds/44910893 This makes me wonder whether I should revert #83 and/or if we should declare a more suitable repository under HTTPS that serves these artifacts. For comparison, https://github.com/glencoesoftware/bioformats2raw/blob/v0.5.0/build.gradle is not using senbox. Thoughts @melissalinkert ? |
I think switching senbox to https://artifacts.glencoesoftware.com/artifactory/unidata-releases is fine. Upgrading jzarr will also require changes in the tests, since the |
This should ensure compatibility with com.bc.zarr:jzarr:0.3.5
@melissalinkert pushed. In addition to updating the tests, I also had to bump the version of With |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had intended to bump bioformats2raw to 0.5.0 anyway as part of adding tests to #82, so this is fine with me.
@chris-allan may feel differently, but I'm not particularly worried about continuing to test with bioformats2raw 0.3.0. We have released versions of raw2ometiff that are known to work with that data, and there isn't really any advantage to upgrading raw2ometiff out of step with bioformats2raw.
Agreed. |
Discovered while reviewing the dependency conflict https://github.com/glencoesoftware/NGFF-Converter
This change aligns the dependencies of raw2ometiff with the ones used in bioformats2raw 0.5.0
Should be amenable for an immediate patch release
0.3.2
as there is no functional or API change