Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new bioformats2raw progress API #92

Merged
merged 4 commits into from
May 30, 2023

Conversation

melissalinkert
Copy link
Member

This won't compile, it's just a place to start. See glencoesoftware/bioformats2raw#172.

Probably main point is whether a hard dependency on bioformats2raw is what we want. If not, that would mean either reimplementing listeners here or putting listeners somewhere else that both bioformats2raw and raw2ometiff can use.

Copy link
Member

@sbesson sbesson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Immediate thought is that if we had an array of Java converters, I could definitely see a value proposition to migrate common utility classes into a shared upstream component. As things stand, my primary concern is that introducing a third component feels a bit overkill though and I do not see off-hand an immediate component where these would belong.

Re the introduction of a bioformats2raw dependency, I am not versed in the original decisions and whether these repositories should be kept as separate. From my side, there is de facto a relationship between bioformats2raw and raw2ometiff, if anything in terms of data layout/specification. In that sense, introducing such dependency does not feel out-of-scope.

@melissalinkert melissalinkert marked this pull request as ready for review May 24, 2023 20:41
@melissalinkert
Copy link
Member Author

Final call for comments, @DavidStirling / @chris-allan. Plan to merge this on Tuesday (May 30) unless any objections.

@melissalinkert melissalinkert merged commit 3dee643 into glencoesoftware:master May 30, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants