Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Reason versions #2

Merged
merged 3 commits into from
Apr 14, 2018
Merged

Add Reason versions #2

merged 3 commits into from
Apr 14, 2018

Conversation

jchavarri
Copy link
Contributor

No description provided.

Copy link
Owner

@glennsl glennsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just have one comment below:

README.md Outdated
@@ -228,6 +330,10 @@ var re = /na/gi;
(* ml *)
let obj = [%obj { property = "value" }]
```
```reason
/* re */
let obj = [%obj {property: "value"}];
Copy link
Owner

@glennsl glennsl Apr 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be nice to show the reason sugar { "property": "value } as an alternative here. What do you think?

@glennsl
Copy link
Owner

glennsl commented Apr 14, 2018

Awesome, thanks!

@glennsl glennsl merged commit f841035 into glennsl:master Apr 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants