3ware: VERIFYING is a normal operation #37
Conversation
The code of check_raid contains an obvious bug in trying
to do a string-compare on a regexp. In
/usr/lib/nagios/plugins/check_raid
check_tw_cli(), line 738:
} elsif ($s eq 'INITIALIZING|VERIFYING') {
The effect is that both status (INITIALIZING and VERIFYING)
will not be recognized and be reported as UNKNOWN. Also
the VERIFYING state will happen as part of a normal operation.
That is especially true if the auto-verification feature
is enabled. To avoid noise this state should be classified
as OK.
Patch was submitted by Harald Wilhelmi <harald.wilhelmi@tngtech.com>
in Debian Bug #689297 (http://bugs.debian.org/689297)
|
can you provide data for test input? please see CONTRIBUTING.md how to provide data for test inputs |
|
btw, this is already fixed in cd25534 released as 3.0.1 |
|
This results in a WARNING, which seems not the same like an OK. As Harald argued with auto-verification this results into periodic noise, but this is not an abnormal condition. Same goes even for the resync of the md software raid. |
|
I'm going to close this PR, regex bug is fixed. making rechecks as WARNING vs OK, is constant request, and they are controversial. so need to make it configurable via command line option to satisfy both parties (ones wanting it to became WARNING and others to stay at OK) for example:
|
|
Enhancing ab3471f for the 'verify' state (I spotted at least 3 occurences in the code) would be great. |
|
You mean use the same commandline parameter for verify states? |
|
at least an option to configure that too, maybe also use this option ... resync and verify are both administrativ jobs where normaly no issue with the array itself are on going. |
|
totally great! |
The code of check_raid contains an obvious bug in trying
to do a string-compare on a regexp. In
The effect is that both status (INITIALIZING and VERIFYING)
will not be recognized and be reported as UNKNOWN. Also
the VERIFYING state will happen as part of a normal operation.
That is especially true if the auto-verification feature
is enabled. To avoid noise this state should be classified
as OK.
Patch was submitted by Harald Wilhelmi harald.wilhelmi@tngtech.com
in Debian Bug #689297 (http://bugs.debian.org/689297)