Remove batchSequenceNumber #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
promag
force-pushed
the
remove-batch-sequence-number
branch
from
0b9b8dc
to
e37e31d
Compare
| @@ -73,12 +71,9 @@ File.prototype._validate = function() { | |||
| File.prototype.addBatch = function(batch) { | |||
|
|
|||
| // Set the batch number on the header and control records | |||
| batch.header.batchNumber.value = batchSequenceNumber | |||
| batch.control.batchNumber.value = batchSequenceNumber | |||
| batch.header.batchNumber.value = this._batches.length | |||
There was a problem hiding this comment.
Although this generates a sequential batch number, it could be useful to have a batchSequenceNumber that could be initialized when creating the File, instead of starting always with 0.
WDYGT?
promag
force-pushed
the
remove-batch-sequence-number
branch
2 times, most recently
from
de4ed02
to
c959f28
Compare
|
|
||
| // Validate all values | ||
|
|
||
| this._batchSequenceNumber = Number(options.batchSequenceNumber) || 0 |
promag
force-pushed
the
remove-batch-sequence-number
branch
from
c959f28
to
e6072ec
Compare
joaopaulofonseca
approved these changes
Sep 29, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR the file generation can be idempotent, ie, it's is possible to create several
Fileobjects with the same setup and each will have the same content. This is most relevant in tests .