-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Serious time for update of stat types #19
Comments
Relates to: #14 |
I think the best way to implement this is to add two new config options where you can set the default speed and size to be displayed.
This also makes it more future proof. Text files will still need to be updated though. To make this future proof as well we could add two new cookies which hold the chosen speed and size indicators. |
It's not just about what is being displayed even tho I agree with what you just proposed as part of the solution, I like your solution. But when adding credits to users it makes more sense to add in MB/GB/TB than in KB so while updating the display of things may help, it does not solve all the problems. |
Giving credits in K/M/G works fine but return is always in K, if that was changed it would probably break a lot of scripts. |
Embarrassed to admit, I didn't even know it was possible giving credits in K/M/G, thought it was only possible in K. Since that is clearly possible then I tend to fully agree with the proposal made by Skeddie. |
RTFM 😄
|
Let's add |
Ok, so I'd like some input regarding which cookies to adjust. So far these are being changed:
Now others that could be changed:
|
I say change all of the "Now others that could be changed:". :D |
That's the kind of input I can't do much with... You want weekly allotment also in GiB if size unit is set to GiB for stats? And which freespace would be in the shared sizeunit Meanwhile other thing changed (but without cookies): |
Ok how about this then
|
It's ZiB or nothing. |
OK, jokes aside. To be clear, we're not talking about adding more cookies; you want those you propose to follow the same sizeunit or speedunit that's been set in config (future |
"you want those you propose to follow the same sizeunit or speedunit that's been set in config (future display_size_unit and display_speed_unit) for the stats so far?" Yes that would be great. |
Also adjusted Done in the soon to appear 2.10beta. |
Things got a lot bigger and faster since glFTPD was first created so the show of KB/s, MB's etc is not relevant to the age we are in now. Same goes for the adding/removing of credits etc that require you to put in KB's instead of MB's. Would be helpful if they were all updated to more relevant stat types such as GB instead of MB and MB/s instead of KB/s etc.
The text was updated successfully, but these errors were encountered: