Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VERSION_GREATER_EQUAL not available in cmake < v3.7 #1584

Closed
papr opened this issue Oct 24, 2019 · 3 comments
Closed

VERSION_GREATER_EQUAL not available in cmake < v3.7 #1584

papr opened this issue Oct 24, 2019 · 3 comments
Assignees
@elmindreda
Labels
bug Bug reports and bugfix pull requests build Build file bugs and PRs (not compilation errors) verified Reproduced or otherwise verified bugs
Milestone
3.3.1

Comments

@papr
Copy link
Contributor

papr commented Oct 24, 2019

The following line causes cmake to fail when using cmake < v3.7 since VERSION_GREATER_EQUAL was introduced in came v3.7.

https://github.com/glfw/glfw/blob/master/src/CMakeLists.txt#L103

if (${CMAKE_VERSION} VERSION_GREATER_EQUAL "3.1.0")
@papr papr mentioned this issue Oct 24, 2019
Closed
@elmindreda elmindreda self-assigned this Oct 24, 2019
@infobeisel
Copy link

for me, it succeeded when i replaced it with VERSION_GREATER (instead of VERSION_GREATER_EQUAL) , using cmake 3.5.1

@tombsar
Copy link
Contributor

tombsar commented Oct 28, 2019

+1 Sorry for not testing this sooner. Does not build with cmake 3.6.2.

With @infobeisel 's change the main library builds ok, but the tests still do not (glfwinfo.c at least contains C99-isms).

@elmindreda elmindreda added this to the 3.3.1 milestone Nov 1, 2019
@elmindreda elmindreda added bug Bug reports and bugfix pull requests build Build file bugs and PRs (not compilation errors) verified Reproduced or otherwise verified bugs labels Nov 1, 2019
@elmindreda
Copy link
Member

Thank you for the fix!

elmindreda pushed a commit that referenced this issue Nov 14, 2019
@papr @elmindreda
Fix CMake 3.0 - 3.6 support regression
411d4dd 
Replaces `VERSION_GREATER_EQUAL` with `VERSION_EQUAL OR
VERSION_GREATER`.  `VERSION_GREATER_EQUAL` was only added in CMake 3.7.

Fixes #1584.
Closes #1585.

(cherry picked from commit 4d0ae4f)
@Themaister Themaister mentioned this issue Dec 15, 2019
Merged
@ailzhang ailzhang mentioned this issue Feb 13, 2020
Closed
aothms added a commit to IfcOpenShell/IfcOpenShell that referenced this issue Mar 26, 2021
@aothms
CMake < 3.7 compatibility
ff7219b 
See glfw/glfw#1584
@lmmx lmmx mentioned this issue Apr 18, 2021
Closed
@evanmiller evanmiller mentioned this issue Jun 4, 2021
Closed
k-okada added a commit to k-okada/openhrp3 that referenced this issue Jun 9, 2022
@k-okada
CMake < 3.7 compatibility, see glfw/glfw#1584
72b1c1a
k-okada added a commit to k-okada/openhrp3 that referenced this issue Jun 9, 2022
@k-okada
CMake < 3.7 compatibility, see glfw/glfw#1584
2bcbdac
k-okada added a commit to k-okada/openhrp3 that referenced this issue Jun 9, 2022
@k-okada
CMake < 3.7 compatibility, see glfw/glfw#1584
aaaf14f
k-okada added a commit to k-okada/openhrp3 that referenced this issue Jun 9, 2022
@k-okada
CMake < 3.7 compatibility, see glfw/glfw#1584
c7cd887
k-okada added a commit to k-okada/openhrp3 that referenced this issue Jun 9, 2022
@k-okada
CMake < 3.7 compatibility, see glfw/glfw#1584
13ff7a0
k-okada added a commit to k-okada/openhrp3 that referenced this issue Jun 10, 2022
@k-okada
CMake < 3.7 compatibility, see glfw/glfw#1584
31da2c5
k-okada added a commit to k-okada/openhrp3 that referenced this issue Jun 10, 2022
@k-okada
CMake < 3.7 compatibility, see glfw/glfw#1584
29565da
m4ce-w1ndu pushed a commit to m4ce-w1ndu/glfw that referenced this issue Jul 23, 2022
@papr @elmindreda
Fix CMake 3.0 - 3.6 support regression
2f35777 
Replaces `VERSION_GREATER_EQUAL` with `VERSION_EQUAL OR
VERSION_GREATER`.  `VERSION_GREATER_EQUAL` was only added in CMake 3.7.

Fixes glfw#1584.
Closes glfw#1585.
@jenniferyee jenniferyee mentioned this issue Sep 23, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elmindreda elmindreda

Labels
bug Bug reports and bugfix pull requests build Build file bugs and PRs (not compilation errors) verified Reproduced or otherwise verified bugs
Projects
None yet
Milestone
3.3.1
Development

Successfully merging a pull request may close this issue.

CMakeLists.txt: Add support for cmake < v3.7
4 participants
@elmindreda @papr @tombsar @infobeisel