Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: Support FriendlyName External Primary #2578

Open
ahaoboy opened this issue Jun 14, 2024 · 1 comment
Open

feature request: Support FriendlyName External Primary #2578

ahaoboy opened this issue Jun 14, 2024 · 1 comment

Comments

@ahaoboy
Copy link

ahaoboy commented Jun 14, 2024

I want to use glfw to print display information similar to fastfatch, but it seems to be missing some interfaces

Display (LG ULTRAGEAR): 3840x2160 @ 144Hz (as 2560x1440) [External]
Display (LG ULTRAGEAR): 3840x2160 @ 144Hz (as 2560x1440) [External] *
println!("{:?} {:?} {:?}", monitor.get_name(), monitor.get_video_mode(), monitor.get_content_scale())

Some("Generic PnP Monitor") Some(3840 x 2160, 24 = 8 + 8 + 8, 144 Hz) (1.5, 1.5)
Some("Generic PnP Monitor") Some(3840 x 2160, 24 = 8 + 8 + 8, 144 Hz) (1.5, 1.5)

monitor.get_name() returning a generic name? it may be easier for users to distinguish between different displays if return a friendlyName based on the deviceId,

External is used to distinguish the integrated display in the notebook and the external display of the desktop computer. It seems that glfw does not have a corresponding API

with_primary_monitor can get the primary monitor, but it is still difficult to determine whether a monitor is the primary monitor. Adding a monitor.is_primary() function seems to be easier to use

@GamesTrap
Copy link
Contributor

Relates to / would be solved by the following PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants