-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a function to get the monitor on which a window is currently being displayed #2404
base: master
Are you sure you want to change the base?
Conversation
One consideration is that it is possible to get the monitor on which a window is currently being displayed by calculating the area a window covers and comparing this to the I'll look into whether the cross platform approach would be best as a fall back implementation or if more 'platform correct' features exist. One thing we may want to consider is the following:
|
Hey good to see you :)) ! I think your proposal is actually the PR I linked in my description. I'll double check the iconified behaviour tomorrow if God wills. I would love the API to return the monitor it will be displayed on if maximised OR nullptr. Also IIRC win32 api provides an ENUM for the way to handle edge cases :
https://learn.microsoft.com/en-us/windows/win32/api/winuser/nf-winuser-monitorfromwindow |
Hello there,
DISCLAIMER: It should be a draft. Not all OSes are implemented and edge cases are probably not properly handled (for instance I need to double check what happens if window is hidden and we call the new function).
Me again with another PR.
This time it is to add a function to retrieve the monitor on which a window is currently being displayed.
It is a different implementation compared to #2220 as I use win32 API MonitorFromWindow here instead of custom logic.
I only did null and win32
PRs are welcome for Linux and Mac OS.
Also I need some feedback on the naming documentation and such.
Cheers,
Scr3am