Add Android Support #1087

xCuri0 · 2017-10-03T08:41:42Z

I added Android support to GLFW. Some features may not be implemented but the basic context creation works.You can test it by importing the native-activity sample in Android Studio, adding GLFW to CMakeLists.txt and changing main.c to be like any normal GLFW program. main() works since the actual entry point is located in android_init.c > android_main(). OpenGL contexts use egl_context.c which required little modification to work.

Vulkan window surface creation uses the VK_KHR_android_surface extension.

I tested it on a Xiaomi Redmi Note 4X, please see if it works on other devices if possible.

very untested may not work at all

untested trying to link it with a native activity results in a linker error

Tested on Xiaomi Redmi Note 4X runnning latest global update

Rendering now works if it is on the main thread

EGL / OpenGL ES also now working

xCuri0 · 2017-10-04T15:37:15Z

@elmindreda Status on this ?

…ethods Rotation also works now

elmindreda · 2017-10-11T15:00:10Z

@xCuri0 I will be back on Sunday and will start looking through this properly then.

elmindreda · 2017-10-11T15:24:32Z

Please hold off on any further updates in the meantime.

elmindreda

This seems to be a good foundation for an Android port! Thank you!

This first review is only about necessary minor cleanup and doesn't really address the design.

elmindreda · 2017-10-15T23:06:04Z

include/GLFW/glfw3.h

@@ -197,7 +197,7 @@ extern "C" {
   #include <OpenGL/glu.h>
  #endif

- #else /*__APPLE__*/
+ #elif !defined(ANDROID) /*__APPLE__*/


Please don't change the default header behavior. I think the application should define one of the GLFW_INCLUDE_ES* macros if that's what the program uses, just like on desktop.

elmindreda · 2017-10-15T23:08:42Z

include/GLFW/glfw3.h

@@ -5207,5 +5207,4 @@ GLFWAPI VkResult glfwCreateWindowSurface(VkInstance instance, GLFWwindow* window
 }
 #endif

-#endif /* _glfw3_h_ */
-
+#endif /* _glfw3_h_ */


Please don't remove EOF newline.

elmindreda · 2017-10-15T23:09:45Z

include/GLFW/glfw3native.h

@@ -564,6 +564,11 @@ GLFWAPI int glfwGetOSMesaDepthBuffer(GLFWwindow* window, int* width, int* height
 GLFWAPI OSMesaContext glfwGetOSMesaContext(GLFWwindow* window);
 #endif

+#if defined(GLFW_EXPOSE_NATIVE_ANDROID)
+#include <android_native_app_glue.h>


Platform headers should be included further up in this file.

elmindreda · 2017-10-15T23:11:21Z

src/CMakeLists.txt

+    set(glfw_HEADERS ${common_HEADERS} android_platform.h android_joystick.h
+                     posix_time.h posix_thread.h)
+    set(glfw_SOURCES ${common_SOURCES} android_init.c android_monitor.c android_window.c
+                     android_joystick.c posix_time.c posix_thread.c egl_context.c osmesa_context.c ${ANDROID_NDK}/sources/android/native_app_glue/android_native_app_glue.c)


Paths that include substitutions should be quoted. Compare with other examples in this file.

elmindreda · 2017-10-15T23:12:03Z

src/CMakeLists.txt

@@ -95,7 +100,8 @@ target_include_directories(glfw PUBLIC
 target_include_directories(glfw PRIVATE
                           "${GLFW_SOURCE_DIR}/src"
                           "${GLFW_BINARY_DIR}/src"
-                           ${glfw_INCLUDE_DIRS})
+                           ${glfw_INCLUDE_DIRS}
+                           ${ANDROID_NDK}/sources/android/native_app_glue/)


Please don't hardcode an NDK path for all platforms; instead add it only when building for Android.

elmindreda · 2017-10-15T23:24:44Z

src/android_window.c

+
+void _glfwPlatformGetWindowSize(_GLFWwindow* window, int* width, int* height)
+{
+    *height = ANativeWindow_getHeight(window->android->window);


Either or both of width and height may be NULL.

elmindreda · 2017-10-17T01:24:42Z

include/GLFW/glfw3native.h

@@ -564,6 +564,11 @@ GLFWAPI int glfwGetOSMesaDepthBuffer(GLFWwindow* window, int* width, int* height
 GLFWAPI OSMesaContext glfwGetOSMesaContext(GLFWwindow* window);
 #endif

+#if defined(GLFW_EXPOSE_NATIVE_ANDROID)
+#include <android_native_app_glue.h>
+GLFWAPI struct android_app * glfwGetAndroidApp(GLFWwindow* window);


There doesn't seem to be a need for a window parameter here as the app struct is available in a global.

elmindreda · 2017-10-17T01:27:03Z

src/android_init.c

+
+const char* _glfwPlatformGetVersionString(void)
+{
+    return _GLFW_VERSION_NUMBER " Android";


The version string should list EGL for Android. See the version strings of other platforms.

elmindreda · 2017-10-17T01:30:55Z

src/android_window.c

+
+    ANativeWindow_setBuffersGeometry(window->android->window, wndconfig->width, wndconfig->height, 0);
+
+    if (ctxconfig->client != GLFW_NO_API) {


GLFW uses Allman style.

elmindreda · 2017-10-17T01:31:43Z

src/android_window.c

+
+void _glfwPlatformGetCursorPos(_GLFWwindow* window, double* xpos, double* ypos)
+{
+    *xpos = x;


Either or both of xpos and ypos may be NULL.

xCuri0 · 2017-10-17T13:17:13Z

@elmindreda I've pushed the changes to my fork but for some reason it doesn't show up in the pull request.

elmindreda · 2017-10-17T13:29:43Z

@xCuri0 Must have been a glitch. Looks like it shows up correctly now.

elmindreda · 2017-10-17T14:53:48Z

Thanks, those are good fixes!

xCuri0 · 2017-10-17T15:18:49Z

@elmindreda Yep it shows for me now too. Also what do you mean by include substitutions should be quoted ?

elmindreda · 2017-11-10T00:05:07Z

@xCuri0 Thank you! Will try it out asap.

kingofoz · 2017-11-28T07:05:39Z

hi @xCuri0 did you fix the segmentation fault error of the cursor state bug?
hi @elmindreda is the android support merged?

Towerthousand · 2017-12-06T13:51:19Z

Hey, tried it out on a Nexus 6P, 5X and a Pixel 2 XL. Really want to get this merged. How can I help this PR move forward? @elmindreda

elmindreda · 2017-12-06T17:43:07Z

@kingofoz Not yet. Currently I'm working on finishing version 3.3.

@Towerthousand Thanks for asking! You can join forces with @xCuri0 to stabilize and flesh out this port or have a look at #1098 for things to do on the 3.3 release.

Jeffset · 2017-12-10T22:22:14Z

@xCuri0 @elmindreda Took a look at this port and played with improving it a bit. And I think it's impressing and promising. But I have a bunch of questions. I can't find a trivial way to attach (f. ex) multitouch events, mobile sensors to existing API. As GLFW not yet designed as library for mobile platforms, does this port going to extend API or rework (generalize somehow) existing one? And what of compatibility? Or maybe only limited set of mobile features'll be available? I'd like to know what do you think of this problems :)
P. S.
I'm chiefly interested in this port and ready to contribute.

elmindreda · 2017-12-10T23:09:14Z

@Jeffset As for touch input, have a look at the touch branch. None yet for sensors. It's quite likely that there will be an official mobile subset of the API if support for Android and iOS pans out.

xCuri0 · 2017-12-12T00:35:20Z

@kingofoz I haven't used a cursor state since it causes segmentation fault.

xCuri0 · 2017-12-26T03:20:13Z

@elmindreda Desktop platforms like Windows and Linux also have APIs for sensors.My laptop has an accelerometer used for HDD protection which can be accessed in Linux.

rafal-tarnow · 2018-01-09T09:22:27Z

good job!, I have tested on Galaxy A5 (2016) Android 6.0.1 and it works

Remove separate thread for Android

WardBenjamin · 2018-06-19T04:28:44Z

Looks awesome! What's the current status on this?

mumin16 · 2018-08-27T14:55:18Z

it cant run the release version

mumin16 · 2018-08-27T16:40:33Z

there is a problem.

xCuri0 · 2018-08-28T02:12:41Z

@mumin16 Can you tell the Android version of the emulator ? I only tested Nougat MIUI and Oreo 8.1 AOSP. Some people got it working on TouchWiz Marshmallow too

evilbinary · 2018-08-28T02:18:27Z

@mumin16 what is your gui?

mumin16 · 2018-08-28T05:40:55Z

i try it:
nox emulator-> 4.4.2
memu emulator->5.1.1

gui is nuklear

evilbinary · 2018-08-28T06:30:08Z

@mumin16 what's your project? Is it open source project?

mumin16 · 2018-08-28T19:35:53Z

if you press the home, application crashes and we get error : A/libc: Fatal signal 11 (SIGSEGV) at 0x00000017 (code=1). we had been trying to call an uninitialised Canvas inside another Class so when it was trying to get the height or width of it, it would crash. if you rotate mobile device, app locks sometimes.

xCuri0 · 2018-08-29T15:56:00Z

@mumin16 both of those are known bugs. I can't implement state saving unless the app using the library stores all its variables in a struct which the library makes

Darky-Lucera · 2019-04-24T12:53:09Z

Excuse me, are there any news ?

tim3385 · 2019-06-29T19:12:39Z

Thanks for your work.
Do you base on touch branch?

kapsyst · 2019-07-30T03:04:30Z

Is there any movement on this? Would be nice to support all platforms via GLFW...

avaxar · 2023-04-08T05:02:04Z

It's been almost 6 years. Would love to see the continuation of progress on this PR.

LDprg · 2024-03-18T05:25:03Z

I think this should actually be revived. Since sdl is the only real alternative supporting android. GLFM for example does not support vulkan so is no real option.

xCuri0 added 16 commits September 8, 2017 21:30

Implement Android skelaton

a833fa4

Fix finding Vulkan on Android

af67cf3

Add Android Vulkan surface creation

b10f4cd

very untested may not work at all

Merge branch 'master' into android_vulkan

046ac02

Add EGL context support and entry point

a49f7b9

untested trying to link it with a native activity results in a linker error

Fix Vulkan library loading on Android

28e66f7

Fix pointer related issues and add glfwGetAndroidApp

83c4c2d

Vulkan now fully working

7848a3c

Tested on Xiaomi Redmi Note 4X runnning latest global update

Fix error where the app would sometimes crash due to app being NULL

672fed8

Merge branch 'master' into android

9b9cfc1

EGL fixes and updated code

49ded3c

More fixes

e1c09aa

Rendering now works if it is on the main thread

Cleanup and refractoring

e5d800c

EGL / OpenGL ES also now working

Merge branch 'master' into android

cbb01b6

Fix CI build

7e56f74

Fix building on Linux

51e0ca0

elmindreda added the enhancement Feature suggestions and PRs label Oct 3, 2017

Polish code

1daf140

xCuri0 mentioned this pull request Oct 7, 2017

Do we have plan for supporting Android or iOS? And other gfx APIs? #611

Open

Add initial input support , fix bugs , refractor and implement some m…

56816cd

…ethods Rotation also works now

elmindreda requested changes Oct 17, 2017

View reviewed changes

xCuri0 added 2 commits October 17, 2017 10:48

Change copyright

57dd782

Adding requested changes

a0d99c8

m0ppers added 2 commits December 2, 2017 11:12

Add framebuffersize() implementation

d8db808

Remove separate thread for android

4d89356

xCuri0 added 3 commits January 16, 2018 18:33

Merge pull request by m0ppers to remove the seperate thread

b27c2fb

Remove separate thread for Android

Add framebuffersize() implementation by m0ppers

302d36d

Merge remote-tracking branch 'upstream/master' into android

ff618d1

jvbsl mentioned this pull request Dec 4, 2018

[4.0] Move Windowing subsystem into the new project. opentk/opentk#866

Closed

linkmauve mentioned this pull request Jul 14, 2020

Possibility for iOS and Android support #1726

Open


		ANativeWindow_setBuffersGeometry(window->android->window, wndconfig->width, wndconfig->height, 0);

		if (ctxconfig->client != GLFW_NO_API) {

Add Android Support #1087

Are you sure you want to change the base?

Add Android Support #1087

Conversation

xCuri0 commented Oct 3, 2017

xCuri0 commented Oct 4, 2017

elmindreda commented Oct 11, 2017

elmindreda commented Oct 11, 2017

elmindreda left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

elmindreda Oct 15, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

elmindreda Oct 17, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

xCuri0 commented Oct 17, 2017

elmindreda commented Oct 17, 2017

elmindreda commented Oct 17, 2017

xCuri0 commented Oct 17, 2017 • edited Loading

elmindreda commented Nov 10, 2017

kingofoz commented Nov 28, 2017

Towerthousand commented Dec 6, 2017

elmindreda commented Dec 6, 2017

Jeffset commented Dec 10, 2017 • edited Loading

elmindreda commented Dec 10, 2017

xCuri0 commented Dec 12, 2017

xCuri0 commented Dec 26, 2017

rafal-tarnow commented Jan 9, 2018

WardBenjamin commented Jun 19, 2018

mumin16 commented Aug 27, 2018 • edited Loading

mumin16 commented Aug 27, 2018

xCuri0 commented Aug 28, 2018 • edited Loading

evilbinary commented Aug 28, 2018

mumin16 commented Aug 28, 2018

evilbinary commented Aug 28, 2018

mumin16 commented Aug 28, 2018

xCuri0 commented Aug 29, 2018

Darky-Lucera commented Apr 24, 2019

tim3385 commented Jun 29, 2019

kapsyst commented Jul 30, 2019

avaxar commented Apr 8, 2023

LDprg commented Mar 18, 2024 • edited Loading

elmindreda Oct 15, 2017 •

edited

Loading

elmindreda Oct 17, 2017 •

edited

Loading

xCuri0 commented Oct 17, 2017 •

edited

Loading

Jeffset commented Dec 10, 2017 •

edited

Loading

mumin16 commented Aug 27, 2018 •

edited

Loading

xCuri0 commented Aug 28, 2018 •

edited

Loading

LDprg commented Mar 18, 2024 •

edited

Loading