Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glfwGetKeyName implementation and bugfix for X11 keypad issue. #117

Closed
wants to merge 10 commits into from

Conversation

dougbinks
Copy link
Contributor

Implementation of glfwGetKeyName as per https://sourceforge.net/p/glfw/discussion/247562/thread/c9bd5374/

This returns a correctly translated key name string in UTF-8 as per the users keyboard and locale settings.

@webhat
Copy link

webhat commented Dec 15, 2013

Doesn't this also solve #114?

@dougbinks
Copy link
Contributor Author

@webhat - this set of commits is prior to the solution I created for #114 but this branch has fixes for both.

@webhat
Copy link

webhat commented Dec 15, 2013

@dougbinks 👍

@elmindreda
Copy link
Member

For people following this issue: this code was not dropped. It lives in the keyboard branch and will be included in 3.1.

@dougbinks
Copy link
Contributor Author

This code has been integrated into the branch keyboard. Unfortutly during a re-org of my own fork the renaming of the branch master to GetKeyName so I could cleanly pull master from glfw caused this pull request to close despite all the commits still being present.

@elmindreda elmindreda added X11 macOS Windows Win32 specific (not Cygwin or WSL) labels Oct 7, 2014
@extrawurst
Copy link

what happened to the keyboard branch and to this GetKeyName function ? I am having issues using glfw to properly recognize CTRL+Z combos correctly on my windows machine...

@elmindreda
Copy link
Member

@extrawurst #464

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
macOS Windows Win32 specific (not Cygwin or WSL) X11
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants