Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1112: simultaneous key presses being dropped #1472

Closed
wants to merge 2 commits into from
Closed

Fix #1112: simultaneous key presses being dropped #1472

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4ea7ed0
Fix #1112: simultaneous key presses being dropped
LucaRood Apr 21, 2019
ba9737e
Merge branch 'master' into fix1112
LucaRood Feb 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Expand Up @@ -176,6 +176,7 @@ information on what to include when reporting a bug.
- [NSGL] Bugfix: `GLFW_COCOA_RETINA_FRAMEBUFFER` had no effect on newer
macOS versions (#1442)
- [NSGL] Bugfix: Workaround for swap interval on 10.14 broke on 10.12 (#1483)
- [X11] Bugfix: Simultanous key presses were being ignored (#1112)


## Contact
Expand Down
3 changes: 2 additions & 1 deletion src/x11_window.c
View file
Open in desktop
Expand Up @@ -1277,7 +1277,8 @@ static void processEvent(XEvent *event)
// These have the same timestamp as the original event
// Corresponding release events are filtered out
// implicitly by the GLFW key repeat logic
if (window->x11.lastKeyTime < event->xkey.time)
if (window->x11.lastKeyTime < event->xkey.time ||
(key != GLFW_KEY_UNKNOWN && window->keys[key] != GLFW_PRESS))
{
if (keycode)
_glfwInputKey(window, key, keycode, GLFW_PRESS, mods);
Expand Down