Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set O_NONBLOCK on wayland key repeat timerfd #1711

Closed
wants to merge 1 commit into from
Closed

set O_NONBLOCK on wayland key repeat timerfd #1711

wants to merge 1 commit into from

Conversation

annacrombie
Copy link
Contributor

would fix #1710

@ninja-
Copy link

ninja- commented Jun 28, 2020

+1

linkmauve
linkmauve requested changes Jun 28, 2020
View reviewed changes
Copy link
Member

@linkmauve linkmauve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from that, LGTM!

src/wl_init.c Outdated Show resolved Hide resolved
src/wl_init.c Outdated Show resolved Hide resolved
@linkmauve linkmauve added bug Bug reports and bugfix pull requests input Keyboard, joystick or mouse Wayland labels Jun 28, 2020
@annacrombie annacrombie force-pushed the fix_wayland_repeat branch 2 times, most recently from 62efeb5 to 245a7e2 Compare June 29, 2020 04:14
@annacrombie
Copy link
Contributor Author

@linkmauve alright! I think it should be good to go. Thanks for your consideration :)

@ninja- ninja- mentioned this pull request Jun 30, 2020
Open
@BailShamber BailShamber mentioned this pull request Feb 19, 2021
Closed
@Clyybber
Copy link

Clyybber commented Jun 1, 2021

ping on this; it makes GLFW usable on wayland without xwayland.

@vchernin vchernin mentioned this pull request Jun 30, 2021
Closed
7 tasks
@luc65r luc65r mentioned this pull request Jul 11, 2021
Merged
11 tasks
@vchernin vchernin mentioned this pull request Jul 21, 2021
Closed
7 tasks
@elmindreda elmindreda self-assigned this Dec 1, 2021
@elmindreda elmindreda added this to Urgent in Queue Dec 1, 2021
@AlynxZhou
Copy link

Any blocker on this PR?

linkmauve added a commit to linkmauve/glfw that referenced this pull request Dec 14, 2021
@linkmauve
Wayland: Continue poll() if timerfd can’t be read
6887908 
In the case the key repeat timerfd was interrupted before read(), the
cursor timerfd wasn’t read at all even when it could.

Related to glfw#1711
@linkmauve linkmauve closed this in 963e728 Dec 14, 2021
@linkmauve
Copy link
Member

This was merged in 963e728 with 6887908 as a follow-up.

Thanks for the patch, and sorry for the delay merging it!

@elmindreda elmindreda added this to the 3.3.7 milestone Dec 15, 2021
@elmindreda elmindreda added the verified Reproduced or otherwise verified bugs label Dec 15, 2021
@elmindreda elmindreda assigned linkmauve and unassigned elmindreda Dec 15, 2021
elmindreda pushed a commit that referenced this pull request Feb 16, 2022
@annacrombie @elmindreda
Wayland: Set O_NONBLOCK on repeat timerfd
8f3677a 
Fixes #1710
Fixes #1711

(cherry picked from commit 963e728)
elmindreda pushed a commit that referenced this pull request Feb 16, 2022
@linkmauve @elmindreda
Wayland: Continue poll() if timerfd can’t be read
52133a3 
In the case the key repeat timerfd was interrupted before read(), the
cursor timerfd wasn’t read at all even when it could.

Related to #1711

(cherry picked from commit 6887908)
@mazunki mazunki mentioned this pull request Apr 6, 2022
Closed
@thiagokokada thiagokokada mentioned this pull request Apr 11, 2022
Merged
swarnimarun pushed a commit to swarnimarun/glfw-meson that referenced this pull request Jul 9, 2022
@annacrombie @swarnimarun
Wayland: Set O_NONBLOCK on repeat timerfd
a51a648 
Fixes glfw#1710
Fixes glfw#1711

(cherry picked from commit 963e728)
swarnimarun pushed a commit to swarnimarun/glfw-meson that referenced this pull request Jul 9, 2022
@linkmauve @swarnimarun
Wayland: Continue poll() if timerfd can’t be read
9fe7071 
In the case the key repeat timerfd was interrupted before read(), the
cursor timerfd wasn’t read at all even when it could.

Related to glfw#1711

(cherry picked from commit 6887908)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linkmauve linkmauve Awaiting requested review from linkmauve

Assignees

@linkmauve linkmauve

Labels
bug Bug reports and bugfix pull requests input Keyboard, joystick or mouse verified Reproduced or otherwise verified bugs Wayland
Projects
Queue
Urgent
Milestone
3.3.7
Development

Successfully merging this pull request may close these issues.

Key repeat timer race condition causing freeze
6 participants
@annacrombie @ninja- @Clyybber @AlynxZhou @linkmauve @elmindreda