Add glfwCreateWindowWGPUSurface for native WebGPU #2333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliemichel
changed the title
|
Use of the WebGPU header LGTM FWIW and I think |
|
It does. It shouldn't change meaningfully, the API already done completely through extension structs. |
|
Hey @elmindreda I see you've added this to your "Needs Investigation" list, is there any way I can help? FWIW I've been actively using this for the past year, and it is a part of the LearnWebGPU guide without trouble, so it's not just me! |
|
WIP support for the new runtime platform switch (X11/Wayland): eliemichel/glfw3webgpu#8 Will be ported to this PR once tested enough. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noticed in #2243 it seems logical that GLFW provides a
glfwCreateWindowWGPUSurfacefor WebGPU similar to theglfwCreateWindowSurfaceit has for Vulkan, as this is the only part of the process of creating a "hello triangle" in native WebGPU that requires OS-specific code (more details).I am not sure about all the details of this PR, I know the original
glfw3webgpurepo works well but maybe I did not integrate it as well as I could in this project's CMakeLists!