Add ID resolver for AWS lambda #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skylerkatz
reviewed
Aug 22, 2024
|
|
||
| public function __destruct() | ||
| { | ||
| $this->release(); |
There was a problem hiding this comment.
Could we do an App::terminating callback in the constructor rather than a destruct?
Or we might end up releasing before verbs commits?
There was a problem hiding this comment.
What's the advantage of App::terminating over __destruct? I think destruct is a little more flexible, but I could be wrong…
There was a problem hiding this comment.
If destruct happens after laravel tears down, could the cache be disconnected?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Snowflakes/etc rely on unique datacenter and worker IDs to operate. Because AWS lambdas are different machines each time, it's impossible to assign each a unique worker/device ID.
This PR adds a new ID resolution mechanism that uses cache locks to acquire a unique ID when required, and then release that ID when the process is terminated. This means that you can effectively have 1024 processes generating unique snowflake IDs in parallel.
By default, Bits will use this mechanism if the
AWS_LAMBDA_FUNCTION_NAMEenvironmental variable is set.