Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass on data received before EOF, which is not terminated by a newline #421

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

nonspecialist
Copy link

Addresses #420

If we go receive an EOF, make sure we pass on any pending data before finishing up

@nonspecialist
Copy link
Author

FYI, we've been running this across about 80 worker nodes for the past 2 weeks, and it's saved quite a few log entries that would otherwise have gone missing.

Copy link

@mattayes mattayes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants