Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Managing knowledge base documents #2876

Merged
merged 18 commits into from Apr 26, 2024
Merged

Feature: Managing knowledge base documents #2876

merged 18 commits into from Apr 26, 2024

Conversation

akanshaaa19
Copy link
Collaborator

No description provided.

@akanshaaa19 akanshaaa19 linked an issue Apr 23, 2024 that may be closed by this pull request
3 tasks
Copy link

cypress bot commented Apr 23, 2024

8 failed and 1 flaky tests on run #4532 ↗︎

8 138 0 29 Flakiness 1

Details:

Merge cc13163 into b6423ef...
Project: Glific Commit: 81bb762ecc ℹ️
Status: Failed Duration: 22:10 💡
Started: Apr 26, 2024 6:59 AM Ended: Apr 26, 2024 7:21 AM
Failed  auth/Login.spec.ts • 1 failed test

View Output

Test Artifacts
Login page > Successful login Test Replay Screenshots
Failed  flow/FlowEditor.spec.ts • 1 failed test

View Output

Test Artifacts
Flow > should configure Flow Test Replay Screenshots
Failed  roles/staff/chat/Chat.spec.ts • 1 failed test

View Output

Test Artifacts
Role - Staff - Chats > should have only chat menu Test Replay Screenshots
Failed  roles/staff/chat/ChatCollection.spec.ts • 1 failed test

View Output

Test Artifacts
Role - Staff - ChatCollection > should send the message to collection Test Replay Screenshots
Failed  roles/staff/chat/Search.spec.ts • 1 failed test

View Output

Test Artifacts
Role - Staff - Chats > should search in chat search Test Replay Screenshots

The first 5 failed specs are shown, see all 8 specs in Cypress Cloud.

Flakiness  cypress/e2e/waGroup/chat/Chat.spec.ts • 1 flaky test

View Output

Test Artifacts
Chats > should send the message correctly Screenshots

Review all test suite changes for PR #2876 ↗︎

Copy link

github-actions bot commented Apr 24, 2024

@github-actions github-actions bot temporarily deployed to pull request April 24, 2024 16:47 Inactive
@github-actions github-actions bot temporarily deployed to pull request April 24, 2024 16:49 Inactive
Copy link

codecov bot commented Apr 24, 2024

Codecov Report

Attention: Patch coverage is 92.72727% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 79.25%. Comparing base (2fb9bec) to head (6465c2a).

Files Patch % Lines
src/containers/KnowledgeBase/KnowledgeBase.tsx 87.75% 5 Missing and 1 partial ⚠️
...sets/images/icons/SideDrawer/KnowledgeBaseIcon.tsx 50.00% 1 Missing ⚠️
...containers/KnowledgeBase/UploadFile/UploadFile.tsx 97.14% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2876      +/-   ##
==========================================
+ Coverage   79.06%   79.25%   +0.18%     
==========================================
  Files         300      306       +6     
  Lines        9478     9584     +106     
  Branches     2037     2052      +15     
==========================================
+ Hits         7494     7596     +102     
- Misses       1370     1373       +3     
- Partials      614      615       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot temporarily deployed to pull request April 25, 2024 09:59 Inactive
@github-actions github-actions bot temporarily deployed to pull request April 25, 2024 10:04 Inactive
@github-actions github-actions bot temporarily deployed to pull request April 25, 2024 15:56 Inactive
@github-actions github-actions bot temporarily deployed to pull request April 26, 2024 04:35 Inactive
@github-actions github-actions bot temporarily deployed to pull request April 26, 2024 05:29 Inactive
@github-actions github-actions bot temporarily deployed to pull request April 26, 2024 05:35 Inactive
@github-actions github-actions bot temporarily deployed to pull request April 26, 2024 06:08 Inactive
@github-actions github-actions bot temporarily deployed to pull request April 26, 2024 06:18 Inactive
@github-actions github-actions bot temporarily deployed to pull request April 26, 2024 06:52 Inactive
Copy link
Member

@mdshamoon mdshamoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code wise looks good. Have not tested functionality. Please ensure everything is working as expected.

src/components/UI/ListIcon/ListIcon.tsx Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pull request April 26, 2024 10:06 Inactive
@github-actions github-actions bot temporarily deployed to pull request April 26, 2024 10:09 Inactive
@akanshaaa19
Copy link
Collaborator Author

Code wise looks good. Have not tested functionality. Please ensure everything is working as expected.

yes @AkhileshNegi and i have tested it, works fine

@mdshamoon mdshamoon self-requested a review April 26, 2024 10:20
@mdshamoon mdshamoon merged commit 28af743 into master Apr 26, 2024
10 of 14 checks passed
@mdshamoon mdshamoon deleted the manage-docs branch April 26, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Manage knowledge base for open LLM
2 participants