Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed file paths for code coverage #2888

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

akanshaaa19
Copy link
Collaborator

No description provided.

Copy link

@github-actions github-actions bot temporarily deployed to pull request May 12, 2024 10:30 Inactive
Copy link

codecov bot commented May 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.28%. Comparing base (b488524) to head (238504d).
Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2888      +/-   ##
==========================================
+ Coverage   79.21%   79.28%   +0.07%     
==========================================
  Files         306      306              
  Lines        9583     9574       -9     
  Branches     2051     2051              
==========================================
  Hits         7591     7591              
+ Misses       1379     1370       -9     
  Partials      613      613              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akanshaaa19 akanshaaa19 requested a review from kurund May 12, 2024 10:36
Copy link

cypress bot commented May 12, 2024

1 flaky test on run #4620 ↗︎

0 175 0 0 Flakiness 1

Details:

Merge 238504d into b488524...
Project: Glific Commit: 75189775e7 ℹ️
Status: Passed Duration: 24:13 💡
Started: May 12, 2024 10:38 AM Ended: May 12, 2024 11:02 AM
Flakiness  cypress/e2e/waGroup/chat/Chat.spec.ts • 1 flaky test

View Output

Test Artifacts
Chats > should send the message correctly Screenshots

Review all test suite changes for PR #2888 ↗︎

Copy link
Contributor

@kurund kurund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed over the call. Let's keep this on hold for now and explore an alternate approach.

@kurund kurund added the on hold This is on hold label May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on hold This is on hold
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants