Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attempt to move to oban vanilla - 01 #2391

Closed

Conversation

TwistingTwists
Copy link
Contributor

Summary

Target issue is - ___________
Explain the motivation for making this change. What existing problem does the pull request solve?

  1. Easy for other users to contribute to the project by incuding Oban Vanilla. as mentioned in discord channel

Checklist

Before submitting a pull request, please ensure that you mark these task.

Notes

Copy link
Collaborator

@siddhant3030 siddhant3030 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TwistingTwists We need a way to still use the oban pro but the key which we need to start the project can be optional. That way anyone can use the project. From what I see you have removed all the dependency for the oban.

@pankaj-ag
Copy link
Member

@siddhant3030 right now that's not possible. I think we need to manage two different branches like master and master-without-oban or something like that.

We need to figure out a way to keep this branch sync with master.

@pankaj-ag
Copy link
Member

@TwistingTwists this looks fine, I will test it today.

@pankaj-ag
Copy link
Member

@TwistingTwists can you try to fix the checks?

@TwistingTwists
Copy link
Contributor Author

@pankaj-ag : updated mix.lock.

I ran mix deps.clean --all and mix deps.get

@pankaj-ag pankaj-ag closed this Aug 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants